Increase timeout for check_rule_active from 60s to 120s#22260
Merged
abdosi merged 2 commits intosonic-net:masterfrom Feb 18, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
We've seen that acl rule installation can take a while as discussed in sonic-net#21988 This check_rule_active/check_rule_counters code was added in sonic-net#21384 but it never worked on DNX due to unsupported SAI calls: sonic-net/sonic-buildimage#24665 Now that we're working around this issue with: sonic-net#22237 We're starting to run into timeouts waiting for ACL rules: Failed: Acl rule counters are not ready Signed-off-by: Nathan Wolfe <[email protected]>
9c8ab96 to
db1856b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
10 tasks
|
|
||
| if duthost.facts['asic_type'] != 'vs': | ||
| pytest_assert(wait_until(60, 2, 0, self.check_rule_active, duthost, table_name), | ||
| pytest_assert(wait_until(120, 2, 0, self.check_rule_active, duthost, table_name), |
Contributor
There was a problem hiding this comment.
Actually, I had trouble getting the test pass even at 120s consistently, so I had to increase this to 150s to get it to pass. Are you seeing consistent success with q3d with this timeout?
Contributor
Author
There was a problem hiding this comment.
We've only ran it a handful of times but all passed. I'm fine with bumping this to 150s as I was also seeing the timings from the logs were pretty close to 120s.
Contributor
Author
There was a problem hiding this comment.
Updated to 150s
Signed-off-by: Nathan Wolfe <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
approved these changes
Feb 18, 2026
Contributor
|
@arista-nwolfe : Please create Issue with slowness of rule insertion |
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
…22260) * Increase timeout for check_rule_active from 60s to 120s We've seen that acl rule installation can take a while as discussed in sonic-net#21988 This check_rule_active/check_rule_counters code was added in sonic-net#21384 but it never worked on DNX due to unsupported SAI calls: sonic-net/sonic-buildimage#24665 Now that we're working around this issue with: sonic-net#22237 We're starting to run into timeouts waiting for ACL rules: Failed: Acl rule counters are not ready Signed-off-by: Nathan Wolfe <[email protected]> * Bump up from 120s to 150s as timeouts are still seen Signed-off-by: Nathan Wolfe <[email protected]> --------- Signed-off-by: Nathan Wolfe <[email protected]> Signed-off-by: Zhuohui Tan <[email protected]>
Contributor
Author
Requested issue: sonic-net/sonic-buildimage#25565 |
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
…22260) * Increase timeout for check_rule_active from 60s to 120s We've seen that acl rule installation can take a while as discussed in sonic-net#21988 This check_rule_active/check_rule_counters code was added in sonic-net#21384 but it never worked on DNX due to unsupported SAI calls: sonic-net/sonic-buildimage#24665 Now that we're working around this issue with: sonic-net#22237 We're starting to run into timeouts waiting for ACL rules: Failed: Acl rule counters are not ready Signed-off-by: Nathan Wolfe <[email protected]> * Bump up from 120s to 150s as timeouts are still seen Signed-off-by: Nathan Wolfe <[email protected]> --------- Signed-off-by: Nathan Wolfe <[email protected]> Signed-off-by: Mihut Aronovici <[email protected]>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 12, 2026
…22260) * Increase timeout for check_rule_active from 60s to 120s We've seen that acl rule installation can take a while as discussed in sonic-net#21988 This check_rule_active/check_rule_counters code was added in sonic-net#21384 but it never worked on DNX due to unsupported SAI calls: sonic-net/sonic-buildimage#24665 Now that we're working around this issue with: sonic-net#22237 We're starting to run into timeouts waiting for ACL rules: Failed: Acl rule counters are not ready Signed-off-by: Nathan Wolfe <[email protected]> * Bump up from 120s to 150s as timeouts are still seen Signed-off-by: Nathan Wolfe <[email protected]> --------- Signed-off-by: Nathan Wolfe <[email protected]> Signed-off-by: Ravali Yeluri (WIPRO LIMITED) <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
…22260) * Increase timeout for check_rule_active from 60s to 120s We've seen that acl rule installation can take a while as discussed in sonic-net#21988 This check_rule_active/check_rule_counters code was added in sonic-net#21384 but it never worked on DNX due to unsupported SAI calls: sonic-net/sonic-buildimage#24665 Now that we're working around this issue with: sonic-net#22237 We're starting to run into timeouts waiting for ACL rules: Failed: Acl rule counters are not ready Signed-off-by: Nathan Wolfe <[email protected]> * Bump up from 120s to 150s as timeouts are still seen Signed-off-by: Nathan Wolfe <[email protected]> --------- Signed-off-by: Nathan Wolfe <[email protected]> Signed-off-by: Abhishek <[email protected]>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…22260) * Increase timeout for check_rule_active from 60s to 120s We've seen that acl rule installation can take a while as discussed in sonic-net#21988 This check_rule_active/check_rule_counters code was added in sonic-net#21384 but it never worked on DNX due to unsupported SAI calls: sonic-net/sonic-buildimage#24665 Now that we're working around this issue with: sonic-net#22237 We're starting to run into timeouts waiting for ACL rules: Failed: Acl rule counters are not ready Signed-off-by: Nathan Wolfe <[email protected]> * Bump up from 120s to 150s as timeouts are still seen Signed-off-by: Nathan Wolfe <[email protected]> --------- Signed-off-by: Nathan Wolfe <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen that acl rule installation can take a while as discussed in #21988
This
check_rule_active/check_rule_counterscode was added in #21384but it never worked on DNX due to unsupported SAI calls: sonic-net/sonic-buildimage#24665
Now that we're working around this issue with:
#22237
We're starting to run into timeouts waiting for ACL rules:
Failed: Acl rule counters are not readyHere are the logs from a failing run where you can see the time it takes for the last ACL rule to be installed takes more than 60s:
We're also increasing the timeout from 60s to 120s for the acl rules in the acl/ package tests here:
#21760
Type of change
Back port request